-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undeprecate cluster slots command #536
Undeprecate cluster slots command #536
Conversation
Signed-off-by: Harkrishn Patro <[email protected]>
@valkey-io/core-team please take a look. Should we update the history as well to indicate we are un-deprecating the command ? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #536 +/- ##
============================================
+ Coverage 69.71% 70.15% +0.43%
============================================
Files 109 109
Lines 61864 59904 -1960
============================================
- Hits 43131 42027 -1104
+ Misses 18733 17877 -856
|
You need to regenerate commands.def . |
No, history is for command argument changes. We can just un-deprecate it. |
I'm going to be more explicit and ask for a vote from @valkey-io/core-team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
We should still mention the drawbacks in the docs and recommend cluster shards for large and very scattered slot distributions. |
Signed-off-by: Harkrishn Patro <[email protected]>
Undeprecate cluster slots command. This command is widely used by clients to form the cluster topology and with the recent change to improve performance of
CLUSTER SLOTS
command via #53 as well as us looking to further improve the usability via #517, it makes sense to undeprecate this command.