Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeprecate cluster slots command #536

Merged
merged 2 commits into from
May 24, 2024

Conversation

hpatro
Copy link
Contributor

@hpatro hpatro commented May 22, 2024

Undeprecate cluster slots command. This command is widely used by clients to form the cluster topology and with the recent change to improve performance of CLUSTER SLOTS command via #53 as well as us looking to further improve the usability via #517, it makes sense to undeprecate this command.

Signed-off-by: Harkrishn Patro <[email protected]>
@hpatro
Copy link
Contributor Author

hpatro commented May 22, 2024

@valkey-io/core-team please take a look.

Should we update the history as well to indicate we are un-deprecating the command ?

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.15%. Comparing base (c478206) to head (33188e3).
Report is 2 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #536      +/-   ##
============================================
+ Coverage     69.71%   70.15%   +0.43%     
============================================
  Files           109      109              
  Lines         61864    59904    -1960     
============================================
- Hits          43131    42027    -1104     
+ Misses        18733    17877     -856     
Files Coverage Δ
src/commands.def 100.00% <ø> (ø)

... and 86 files with indirect coverage changes

@madolson
Copy link
Member

You need to regenerate commands.def .

@madolson
Copy link
Member

Should we update the history as well to indicate we are un-deprecating the command ?

No, history is for command argument changes. We can just un-deprecate it.

@madolson
Copy link
Member

I'm going to be more explicit and ask for a vote from @valkey-io/core-team.

@madolson madolson added the major-decision-pending Major decision pending by TSC team label May 22, 2024
Copy link
Member

@enjoy-binbin enjoy-binbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zuiderkwast
Copy link
Contributor

We should still mention the drawbacks in the docs and recommend cluster shards for large and very scattered slot distributions.

@madolson madolson added needs-doc-pr This change needs to update a documentation page. Remove label once doc PR is open. major-decision-approved Major decision approved by TSC team release-notes This issue should get a line item in the release notes and removed major-decision-pending Major decision pending by TSC team labels May 23, 2024
Signed-off-by: Harkrishn Patro <[email protected]>
@zuiderkwast zuiderkwast merged commit 3dd2f5a into valkey-io:unstable May 24, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-decision-approved Major decision approved by TSC team needs-doc-pr This change needs to update a documentation page. Remove label once doc PR is open. release-notes This issue should get a line item in the release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants