Add util tag in unit-test name of util to be consistent with other tests and rename tempfile name to valkey-recliam-cache-test #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #549 +/- ##
============================================
- Coverage 70.23% 70.20% -0.03%
============================================
Files 109 109
Lines 59955 59955
============================================
- Hits 42110 42093 -17
- Misses 17845 17862 +17 |
madolson
reviewed
May 28, 2024
| @@ -268,13 +268,13 @@ static int cache_exist(int fd) { | |||
| } | |||
| #endif | |||
|
|
|||
| int test_reclaimFilePageCache(int argc, char **argv, int flags) { | |||
| int test_utilReclaimFilePageCache(int argc, char **argv, int flags) { | |||
There was a problem hiding this comment.
I don't know if I buy this. We don't really have a naming convention here. If you want to define a naming convention, can you document it in the readme?
There was a problem hiding this comment.
Unknowingly we all followed the format but only one file's test cases were missed. As you suggested, updated readme file content (Not added specific block for naming convetion). I hope changed content is enough to follow, Please let me know if we need to have a seperate block for naming conventions.
Shivshankar-Reddy
force-pushed
the
test-util-testname
branch
from
a32aa04
to
473e233
Compare
…lkey* Signed-off-by: Shivshankar-Reddy <[email protected]>
Signed-off-by: Shivshankar-Reddy <[email protected]>
hwware
force-pushed
the
test-util-testname
branch
from
473e233
to
02c0cac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.