Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all little inconsistencies in the json command file descriptions #63

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

pragnesh
Copy link
Contributor

@pragnesh pragnesh commented Mar 28, 2024

Partial fix for #40.
I want to get feedback before making more changes, Please review.

Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good. You may need to run make and check in some generated file.

src/commands/role.json Outdated Show resolved Hide resolved
src/commands/role.json Outdated Show resolved Hide resolved
@pragnesh
Copy link
Contributor Author

pragnesh commented Mar 29, 2024

Very good. You may need to run make and check in some generated file.

I tried building documentation but getting error

#utils/generate-commands-json.py
Traceback (most recent call last):
  File "/data2/valkey/valkey/utils/generate-commands-json.py", line 117, in <module>
    p = subprocess.Popen([args.cli, '-h', args.host, '-p', str(args.port), '--json', 'command'], stdout=subprocess.PIPE)
  File "/home/pragnesh/.pyenv/versions/3.10.8/lib/python3.10/subprocess.py", line 971, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/home/pragnesh/.pyenv/versions/3.10.8/lib/python3.10/subprocess.py", line 1847, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: '/data2/valkey/valkey/src/redis-cli'

I am not sure what is correct way to build documentation. Please suggest.

@zuiderkwast
Copy link
Contributor

The binary redis-cli has been renamed? There are many PRs now.

@zuiderkwast zuiderkwast merged commit 42e0063 into valkey-io:unstable Apr 2, 2024
15 checks passed
@zuiderkwast zuiderkwast added the polish typos, style, etc label Apr 2, 2024
PatrickJS pushed a commit to PatrickJS/placeholderkv that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
polish typos, style, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix all the little inconsistencies in the json command file descriptions
2 participants