Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(earn): Add earn_supported_pools dynamic config #6112

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

finnian0826
Copy link
Contributor

@finnian0826 finnian0826 commented Sep 30, 2024

Description

and use in getEarnPositions query. Opted to have the default be the empty list and have the legacy default live in hooks (here). That way if we need to change the legacy default we can and there won't be BC issues in the wallet (can just change on hooks side without release, goes to all versions).

Dynamic config: https://console.statsig.com/4plizaPmWwPL21ASV4QAO0/dynamic_configs/supported_earn_pools

Test plan

CI

Related issues

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.74%. Comparing base (2a6433e) to head (2a52e20).
Report is 11 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main    #6112    +/-   ##
========================================
  Coverage   88.74%   88.74%            
========================================
  Files         727      727            
  Lines       30786    30790     +4     
  Branches     5626     5626            
========================================
+ Hits        27322    27326     +4     
- Misses       3265     3420   +155     
+ Partials      199       44   -155     
Files with missing lines Coverage Δ
src/positions/saga.ts 91.23% <100.00%> (+0.18%) ⬆️
src/statsig/constants.ts 100.00% <ø> (ø)
src/statsig/types.ts 100.00% <100.00%> (ø)

... and 67 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a6433e...2a52e20. Read the comment docs.

@finnian0826 finnian0826 added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit 04bb249 Oct 1, 2024
15 checks passed
@finnian0826 finnian0826 deleted the finnian0826/act-1367 branch October 1, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants