Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add demo mode entry in onboarding screen #6453

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

kathaypacific
Copy link
Collaborator

Description

The scope of this PR is limited to:

  1. adding dynamic config to support launching and displaying demo mode
  2. adding the entry point in onboarding to launch demo mode
  3. displaying the app with some indication that demo mode is active (I've added the gradient border for now)

Test plan

(It's not clear in the video but for the first 5 seconds, I am long pressing the logo)

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-01-27.at.13.09.24.mp4

Related issues

Backwards compatibility

Y

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

custom: {
startOnboardingTime: startOnboardingTimeSelector(state),
startOnboardingTime: state.account.startOnboardingTime,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing these selectors allowed me to break the cyclical dependency of statsig -> walletAddressSelector in src/web3/selectors -> statsig. this cycle was causing the imports from statsig to be undefined, which caused tests to fail (since you cannot pass undefined to createSelector). i don't see any problems with having no userID / the previous userID during demo mode

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 95.91837% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.10%. Comparing base (f34cfbe) to head (c5ef646).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/web3/reducer.ts 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6453      +/-   ##
==========================================
- Coverage   89.11%   89.10%   -0.02%     
==========================================
  Files         733      731       -2     
  Lines       31907    31854      -53     
  Branches     6099     6090       -9     
==========================================
- Hits        28433    28382      -51     
+ Misses       3427     3279     -148     
- Partials       47      193     +146     
Files with missing lines Coverage Δ
src/account/selectors.ts 96.96% <ø> (-0.09%) ⬇️
src/navigator/NavigatorWrapper.tsx 72.64% <100.00%> (+1.64%) ⬆️
src/onboarding/welcome/Welcome.tsx 98.38% <100.00%> (+0.42%) ⬆️
src/redux/migrations.ts 97.01% <100.00%> (+<0.01%) ⬆️
src/redux/store.ts 89.23% <ø> (ø)
src/statsig/constants.ts 100.00% <ø> (ø)
src/statsig/index.ts 98.91% <100.00%> (-0.03%) ⬇️
src/statsig/types.ts 100.00% <100.00%> (ø)
src/web3/actions.ts 100.00% <100.00%> (ø)
src/web3/selectors.ts 100.00% <100.00%> (ø)
... and 2 more

... and 74 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f34cfbe...c5ef646. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant