-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add demo mode entry in onboarding screen #6453
base: main
Are you sure you want to change the base?
Conversation
custom: { | ||
startOnboardingTime: startOnboardingTimeSelector(state), | ||
startOnboardingTime: state.account.startOnboardingTime, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing these selectors allowed me to break the cyclical dependency of statsig -> walletAddressSelector in src/web3/selectors -> statsig. this cycle was causing the imports from statsig to be undefined, which caused tests to fail (since you cannot pass undefined to createSelector
). i don't see any problems with having no userID / the previous userID during demo mode
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6453 +/- ##
==========================================
- Coverage 89.11% 89.10% -0.02%
==========================================
Files 733 731 -2
Lines 31907 31854 -53
Branches 6099 6090 -9
==========================================
- Hits 28433 28382 -51
+ Misses 3427 3279 -148
- Partials 47 193 +146
... and 74 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Description
The scope of this PR is limited to:
Test plan
(It's not clear in the video but for the first 5 seconds, I am long pressing the logo)
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-01-27.at.13.09.24.mp4
Related issues
Backwards compatibility
Y
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: