Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cico): Add experiment and update enter amount screen #6458

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

finnian0826
Copy link
Contributor

@finnian0826 finnian0826 commented Jan 29, 2025

Description

Matches designs for cash-in flow when experiment is treatment.

Updated some fonts/colors to match designs (across all variants/flows)

Test plan

Unit tests added/updates

Related issues

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 89.08%. Comparing base (0ab67bc) to head (9c0c23d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/fiatExchanges/FiatExchangeAmount.tsx 68.42% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6458      +/-   ##
==========================================
- Coverage   89.09%   89.08%   -0.02%     
==========================================
  Files         731      730       -1     
  Lines       31816    31841      +25     
  Branches     5769     5779      +10     
==========================================
+ Hits        28348    28367      +19     
- Misses       3422     3428       +6     
  Partials       46       46              
Files with missing lines Coverage Δ
src/analytics/Properties.tsx 100.00% <ø> (ø)
src/statsig/constants.ts 100.00% <ø> (ø)
src/statsig/types.ts 100.00% <100.00%> (ø)
src/fiatExchanges/FiatExchangeAmount.tsx 82.30% <68.42%> (+0.41%) ⬆️

... and 15 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ab67bc...9c0c23d. Read the comment docs.

@finnian0826 finnian0826 marked this pull request as ready for review January 29, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant