Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove default props #6461

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

fix: make props optional that have defaults set

6417658
Select commit
Loading
Failed to load commit list.
Open

chore: remove default props #6461

fix: make props optional that have defaults set
6417658
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 30, 2025 in 0s

89.09% (target 75.00%)

View this Pull Request on Codecov

89.09% (target 75.00%)

Details

Codecov Report

Attention: Patch coverage is 90.47619% with 6 lines in your changes missing coverage. Please review.

Project coverage is 89.09%. Comparing base (bfef6e8) to head (6417658).

Files with missing lines Patch % Lines
src/components/KeyboardSpacer.tsx 44.44% 5 Missing ⚠️
src/navigator/Headers.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main    #6461    +/-   ##
========================================
  Coverage   89.09%   89.09%            
========================================
  Files         730      730            
  Lines       31827    31840    +13     
  Branches     5771     6121   +350     
========================================
+ Hits        28355    28367    +12     
+ Misses       3426     3278   -148     
- Partials       46      195   +149     
Files with missing lines Coverage Δ
src/components/BackButton.tsx 100.00% <100.00%> (ø)
src/components/CircleButton.tsx 100.00% <100.00%> (ø)
src/components/CurrencyDisplay.tsx 66.94% <100.00%> (-0.28%) ⬇️
src/icons/BackChevron.tsx 100.00% <100.00%> (ø)
src/icons/Backspace.tsx 100.00% <100.00%> (ø)
src/icons/BankIcon.tsx 100.00% <100.00%> (ø)
src/icons/Checkmark.tsx 100.00% <100.00%> (ø)
src/icons/ClockIcon.tsx 100.00% <100.00%> (ø)
src/icons/Envelope.tsx 100.00% <100.00%> (ø)
src/icons/Error.tsx 100.00% <100.00%> (ø)
... and 11 more

... and 63 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfef6e8...6417658. Read the comment docs.