feat: add demo mode indicator and exit functionality #6465
+200
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kathaypacific
commented
Jan 31, 2025
| @@ -63,6 +64,7 @@ export function* watchRefreshBalances() { | |||
| createFiatConnectTransferCompleted.type, | |||
| depositTransactionSucceeded.type, | |||
| swapSuccess.type, | |||
| Web3Actions.DEMO_MODE_TOGGLED, | |||
There was a problem hiding this comment.
seems sensible to refresh the balances when the demo mode is toggled. the balances sagas are terminating early if there is no address anyway
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6465 +/- ##
========================================
Coverage 89.05% 89.06%
========================================
Files 730 731 +1
Lines 31895 31922 +27
Branches 5792 6107 +315
========================================
+ Hits 28405 28431 +26
+ Misses 3443 3294 -149
- Partials 47 197 +150
... and 70 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the title, this PR adds:
Test plan
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-01-31.at.17.15.57.mp4
Related issues
Backwards compatibility
Y
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: