Feat/activation round #96
Conversation
| def check_payload(self, payload: BaseTxPayload) -> None: | ||
| """Check payload.""" | ||
| raise NotImplementedError | ||
| _ = Event.AWAITING_BONDING |
There was a problem hiding this comment.
to pass linter. It can be removed. I think entire waiting round may be removed. Let me know your opinion on this then we may open an issue on it
There was a problem hiding this comment.
Why do you think it can be removed?
There was a problem hiding this comment.
the activation round can take care of all this logic. It can compute the actual difference between bonding and last block, and decide to sleep for that long (or until timeout hits) before attempting to activate.
There was a problem hiding this comment.
If we can remove a round without changing the logic or complicating the implementation too much, then I would suggest that we do this.
Karrenbelt
force-pushed
the
feat/activation_round
branch
from
faef933 to
c1b5cc6
Compare
| contract_id=str(Keep3rV1Contract.contract_id), | ||
| contract_callable="build_activation_tx", | ||
| ) | ||
| activation_tx = cast(str, contract_api_response.state.body.get("data")) |
There was a problem hiding this comment.
Missing performative check and handling
fix/job selection
activation- round & behaviour and associated tests