feat: Enhance investment pool functionality and error handling #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
princevijay27
commented
Feb 27, 2025
princevijay27
commented
- Modified filter criteria for investment pool selection
- Updated token investment logic for better performance
- Implemented error handling for large numerical values
- Expanded pool selection range for increased flexibility
- Added fallback calculation for zero APR base
- Introduced investment caps and validation
- Added multi-pool functionality and updated partial position reallocation
- Modified filter criteria for investment pool selection - Updated token investment logic for better performance - Implemented error handling for large numerical values - Expanded pool selection range for increased flexibility - Added fallback calculation for zero APR base - Introduced investment caps and validation - Added multi-pool functionality and updated partial position reallocation
- Modified filter criteria for investment pool selection - Updated token investment logic for better performance - Implemented error handling for large numerical values - Expanded pool selection range for increased flexibility - Added fallback calculation for zero APR base - Introduced investment caps and validation - Added multi-pool functionality and updated partial position reallocation
| if sharpe_ratio <= SHARPE_RATIO_THRESHOLD: | ||
| logs.append(f"Opportunity does not meet the {SHARPE_RATIO_THRESHOLD=}") | ||
| continue | ||
| # if sharpe_ratio <= SHARPE_RATIO_THRESHOLD: |
There was a problem hiding this comment.
why comment these lines?
There was a problem hiding this comment.
still not resolved
DIvyaNautiyal07
requested changes
Mar 3, 2025
| if len(assets) != len(max_amounts_in): | ||
| raise ValueError("Length of assets and max_amounts_in must match") | ||
|
|
||
| # Initialize the new amounts list with zeros |
There was a problem hiding this comment.
Could you update the logging statements? They aren’t very clear right now and could be more descriptive.
DIvyaNautiyal07
requested changes
Mar 4, 2025
| @@ -172,23 +168,13 @@ def adjust_amounts(self, assets, max_amounts_in, assets_new): | |||
|
|
|||
| # Initialize the new amounts list with zeros | |||
| new_max_amounts_in = [0] * len(assets_new) | |||
| self.context.logger.info(f"Initial new_max_amounts_in: {new_max_amounts_in}") | |||
There was a problem hiding this comment.
don't remove the logs just add more descriptive logs
…that were added for testing purposes
…that were added for testing purposes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.