Get notification shade name in current system language for event.text matching ( #23 ) #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Syahriel Ibnu Irfansyah <[email protected]>
EmiyaSyahriel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #23 , but I am using a APIs that is discouraged by Android documentation.
How this works is we load System UI resources, get the string for the notification shade name in current system language and then return it for
event.textmatching. It will fallback to"Notification shade"in case the string resource is no longer named this way. and this call should be compatible from Android API 19 KitKat (or maybe older) up to the latest Android API 34.The loading System UI resource part would require some additional RAM, therefore there might be some hiccup on some lower-end device.
EDIT : I have to sign my commit and force-push it, I forgot to setup my git client here 🙂
What do you think about this?