Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Add versionCode for checking exact bundle #24

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Stoneski93
Copy link

@Stoneski93 Stoneski93 commented Jan 16, 2025

Add an build number checking to manage bundles in app.
Some developers bump only buildNumber and in this case package react on version or build update.

@Stoneski93 Stoneski93 changed the title Feature/Add buildNumber like an option Feature/Add versionCode for checking exact bundle Jan 16, 2025
@vantuan88291
Copy link
Owner

Thanks for your PR, can you explain more why need add buildNumber in there?

@Stoneski93
Copy link
Author

Stoneski93 commented Jan 17, 2025

Yeah, I used to worked on projects where we bumped buildNumber only. Your package for now only react on change version.
We can have situation where we got version 1.0.0 and next builds will be builds that only when we change build numbers. So we can have update for specific version and build number, not only for version.

@vantuan88291
Copy link
Owner

I understand your point, but this library let you control the version from your backend side, i think you can refer this issue and see whether it can resolve your issue: #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants