Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure the LEFT JOIN behaves as expected #620

Closed
wants to merge 0 commits into from
Closed

Conversation

bwdmr
Copy link

@bwdmr bwdmr commented Oct 31, 2024

The WHERE clause will filter out these rows because NULL values do not satisfy either the IS NULL or the greater than conditions, effectively excluding them from the result set.

Turning the LEFT JOIN into an INNER JOIN for rows where NULL values would have been expected.

  • move includeDeleted checks from query to join, where the filter will be applied
  • copy filters over and add filter as necessary, on case deleted in not included
  • keep includeDeleted checks within query aswell, as null checks now can exists in where clause aswell.
  • adjust tests to reflect changes in code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant