ensure the LEFT JOIN behaves as expected #623
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WHERE clause will filter out these rows because NULL values do not satisfy either the IS NULL or the greater than conditions, effectively excluding them from the result set. Turning the LEFT JOIN into an INNER JOIN for rows where NULL values would have been expected. * move includeDeleted checks from query to join, where the filter will be applied * copy filters over and add filter as necessary, on case deleted in not included * keep includeDeleted checks within query aswell, as null checks now can exists in where clause aswell. * adjust tests to reflect changes in code.
gwynne
requested changes
Jan 2, 2025
remove conformity to equatable for query action
…L optimization incorporate changes in test cases
bwdmr
force-pushed
the
leftjointimestamp
branch
from
7c4f2c7 to
88fbec7
Compare
bwdmr
force-pushed
the
leftjointimestamp
branch
from
33236f1 to
983cd12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WHERE clause will filter out these rows because NULL values do not satisfy either the IS NULL or the greater than conditions, effectively excluding them from the result set.
Turning the LEFT JOIN into an INNER JOIN for rows where NULL values would have been expected.