Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace VM resource's wait_for_ip functionality to validate it whether the ip(s) match a given prefix #305

Merged
merged 7 commits into from
Mar 20, 2024

Conversation

ddelnano
Copy link
Collaborator

@ddelnano ddelnano commented Mar 1, 2024

Summary: Replace VM resource's wait_for_ip functionality to validate it whether the ip(s) match a given prefix

This PR is a work in progress change for addressing #300.

Testing done:

  • Replace existing functionality with a network block scoped expected_ip_cidr
  • Implement matching logic for multiple cidr ranges
  • Add test that simulates an upgrade from the previous wait_for_ip to the current per network interface expected_cidr_range configuration.

@ddelnano ddelnano force-pushed the enhance-wait_for_ip-vm-resource-functionality branch from a337519 to 77447f8 Compare March 18, 2024 23:01
…idr_range works as expected

Signed-off-by: Dom Del Nano <[email protected]>
@ddelnano ddelnano force-pushed the enhance-wait_for_ip-vm-resource-functionality branch 2 times, most recently from 7a244cb to 090607d Compare March 19, 2024 05:07
@ddelnano ddelnano force-pushed the enhance-wait_for_ip-vm-resource-functionality branch from 090607d to 00bdb44 Compare March 19, 2024 06:59
@ddelnano ddelnano merged commit 516842d into master Mar 20, 2024
4 checks passed
@ddelnano ddelnano deleted the enhance-wait_for_ip-vm-resource-functionality branch March 20, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant