Skip to content

Commit

Permalink
Fix typo in batch job (#2708)
Browse files Browse the repository at this point in the history
Co-authored-by: Kiichiro YUKAWA <[email protected]>
  • Loading branch information
2 people authored and vdaas-ci committed Oct 22, 2024
1 parent b357952 commit 5c91600
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion pkg/gateway/mirror/usecase/vald.go
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ func (r *run) Stop(ctx context.Context) (errs error) {
return errs
}

// PtopStop is a method called after execution of Stop.
// PostStop is a method called after execution of Stop.
func (*run) PostStop(_ context.Context) error {
return nil
}
2 changes: 1 addition & 1 deletion pkg/index/job/creation/service/indexer.go
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ func (idx *index) doCreateIndex(
switch {
case errors.Is(err, context.Canceled):
err = status.WrapWithCanceled(
agent.CreateIndexRPCName+" API canceld", err,
agent.CreateIndexRPCName+" API canceled", err,

Check warning on line 178 in pkg/index/job/creation/service/indexer.go

View check run for this annotation

Codecov / codecov/patch

pkg/index/job/creation/service/indexer.go#L178

Added line #L178 was not covered by tests
)
attrs = trace.StatusCodeCancelled(err.Error())
case errors.Is(err, context.DeadlineExceeded):
Expand Down
2 changes: 1 addition & 1 deletion pkg/index/job/creation/usecase/creation.go
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ func (r *run) Stop(ctx context.Context) (errs error) {
return errs
}

// PtopStop is a method called after execution of Stop.
// PostStop is a method called after execution of Stop.
func (*run) PostStop(_ context.Context) error {
return nil
}
2 changes: 1 addition & 1 deletion pkg/index/job/readreplica/rotate/usecase/rotate.go
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ func (r *run) Stop(ctx context.Context) (errs error) {
return errs
}

// PtopStop is a method called after execution of Stop.
// PostStop is a method called after execution of Stop.
func (*run) PostStop(_ context.Context) error {
return nil
}
2 changes: 1 addition & 1 deletion pkg/index/job/save/service/indexer.go
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ func (idx *index) doSaveIndex(
switch {
case errors.Is(err, context.Canceled):
err = status.WrapWithCanceled(
agent.SaveIndexRPCName+" API canceld", err,
agent.SaveIndexRPCName+" API canceled", err,

Check warning on line 174 in pkg/index/job/save/service/indexer.go

View check run for this annotation

Codecov / codecov/patch

pkg/index/job/save/service/indexer.go#L174

Added line #L174 was not covered by tests
)
attrs = trace.StatusCodeCancelled(err.Error())
case errors.Is(err, context.DeadlineExceeded):
Expand Down
2 changes: 1 addition & 1 deletion pkg/index/job/save/usecase/save.go
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ func (r *run) Stop(ctx context.Context) (errs error) {
return errs
}

// PtopStop is a method called after execution of Stop.
// PostStop is a method called after execution of Stop.
func (*run) PostStop(_ context.Context) error {
return nil
}
2 changes: 1 addition & 1 deletion pkg/index/operator/usecase/operator.go
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ func (r *run) Stop(ctx context.Context) (errs error) {
return errs
}

// PtopStop is a method called after execution of Stop.
// PostStop is a method called after execution of Stop.
func (*run) PostStop(_ context.Context) error {
return nil
}

0 comments on commit 5c91600

Please sign in to comment.