Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI]: Increase the maximum limit of the gh pr list command #2683

Merged
merged 1 commit into from
Oct 8, 2024
Merged

[CI]: Increase the maximum limit of the gh pr list command #2683

merged 1 commit into from
Oct 8, 2024

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented Oct 8, 2024 •
edited by coderabbitai bot
Loading

Description

WHAT

I have Increased the maximum limit of the gh pr list command.

WHY

Due to the low maximum limit, we couldn't retrieve the appropriate list of PRs, and the creation of the backport PR failed.

Related Issue

Versions

  • Vald Version: v1.7.13
  • Go Version: v1.23.2
  • Rust Version: v1.81.0
  • Docker Version: v27.3.1
  • Kubernetes Version: v1.31.1
  • Helm Version: v3.16.1
  • NGT Version: v2.2.4
  • Faiss Version: v1.8.0

Checklist

Special notes for your reviewer

Summary by CodeRabbit

  • Chores
    • Increased the limit of pull requests fetched in the workflow from 10 to 100, enhancing the context available for backporting.

@hlts2
fix: increase limit
05b1a62 
Signed-off-by: hlts2 <[email protected]>
@hlts2 hlts2 self-assigned this Oct 8, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 8, 2024 •
edited
Loading

📝 Walkthrough

Walkthrough

The pull request modifies the GitHub Actions workflow file backport.yaml by increasing the limit of pull requests fetched from 10 to 100 in the Fetch PR info step. This change allows the workflow to retrieve a larger number of merged pull requests, potentially providing more context for backporting tasks. No other significant changes to the workflow's logic or control flow are included.

Changes

File Change Summary
.github/workflows/backport.yaml Increased pull request fetch limit from 10 to 100 in the Fetch PR info step.

Possibly related PRs

  • Backport PR #2542, #2538 to release/v1.7 #2543: This PR modifies the GitHub Actions workflow file .github/workflows/backport.yml, which is related to the backporting process, similar to the changes made in the backport.yaml file in the main PR.

Suggested labels

priority/low, size/XXXL

Suggested reviewers

  • kmrmt
  • datelier

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Oct 8, 2024

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@hlts2 hlts2 requested review from a team, kpango and datelier and removed request for a team October 8, 2024 10:14
@hlts2 hlts2 requested a review from vankichi October 8, 2024 10:14
@github-actions github-actions bot added the size/S label Oct 8, 2024
coderabbitai[bot]
coderabbitai bot reviewed Oct 8, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
.github/workflows/backport.yaml (1)

53-55: Approved: Increased PR fetch limit addresses the stated objective.

The change from 10 to 100 in the gh pr list command's limit aligns with the PR's objective to increase the maximum limit for retrieving pull requests. This should help prevent failures in creating backport PRs due to insufficient PR information.

However, consider the following:

  1. This change may increase the execution time of this step. Monitor the workflow's performance to ensure it doesn't significantly impact overall execution time.
  2. Be aware of potential GitHub API rate limit issues if this workflow runs frequently. Consider implementing rate limiting or caching mechanisms if needed.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 83de9c8 and 05b1a62.

📒 Files selected for processing (1)
  • .github/workflows/backport.yaml (1 hunks)
🧰 Additional context used

@kpango kpango merged commit 95d7e81 into main Oct 8, 2024
53 checks passed
@kpango kpango deleted the fix/ci/increase-pr-get-limit branch October 8, 2024 23:15
vdaas-ci pushed a commit that referenced this pull request Oct 8, 2024
@hlts2 @vdaas-ci
fix: increase limit (#2683)
d919f13 
Signed-off-by: hlts2 <[email protected]>
kpango pushed a commit that referenced this pull request Oct 9, 2024
@vdaas-ci @hlts2
fix: increase limit (#2683) (#2686)
4b58aa2 
Signed-off-by: hlts2 <[email protected]>
Co-authored-by: Hiroto Funakoshi <[email protected]>
@coderabbitai coderabbitai bot mentioned this pull request Oct 9, 2024
Merged
2 tasks
@kpango kpango mentioned this pull request Oct 11, 2024
Merged
@github-actions github-actions bot mentioned this pull request Nov 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

@kpango kpango kpango approved these changes

@datelier datelier Awaiting requested review from datelier datelier was automatically assigned from vdaas/maintainer

@vankichi vankichi Awaiting requested review from vankichi

Assignees

@hlts2 hlts2

Labels
actions/backport/release/v1.7 priority/low size/S type/ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hlts2 @vdaas-ci @kpango