-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add skip count license header lines #2849
Conversation
📝 WalkthroughWalkthroughThis pull request modifies the Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant GDeps as go/deps Target
participant Shell as Shell Commands
Dev->>GDeps: Execute go/deps target
GDeps->>Shell: Read $(ROOTDIR)/hack/go.mod.default
Shell-->>GDeps: Return file content
GDeps->>Shell: Filter and sort module lines
Shell-->>GDeps: Return processed data
GDeps->>Shell: Update Go version in file
Shell-->>GDeps: Confirm update
GDeps->>Dev: Return completion status
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
[CHATOPS:HELP] ChatOps commands.
|
2676396
to
e335c64
Compare
Deploying vald with
|
Latest commit: |
9090f6e
|
Status: | ✅ Deploy successful! |
Preview URL: | https://65fa48d2.vald.pages.dev |
Branch Preview URL: | https://bugfix-charts-yaml-format.vald.pages.dev |
Signed-off-by: vankichi <[email protected]>
Co-authored-by: Yusuke Kato <[email protected]> Signed-off-by: Kosuke Morimoto <[email protected]>
af1967a
to
9090f6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
Makefile.d/dependencies.mk (1)
75-75
: 🛠️ Refactor suggestionReplace discouraged command and avoid error suppression.
The command
go get -u all
is discouraged in Go modules as it can lead to unexpected version upgrades. Additionally, suppressing errors with2>/dev/null
can hide important issues.Apply this diff to use the recommended approach:
- go get -u all 2>/dev/null || true + # Update dependencies to latest minor/patch versions + go get -u=patch ./... || echo "Warning: Some patches could not be applied"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
hack/license/gen/main.go
is excluded by!**/gen/**
📒 Files selected for processing (1)
Makefile.d/dependencies.mk
(1 hunks)
Description
SSIA
Merge only this or #2851
Related Issue
Versions
Checklist
Special notes for your reviewer
Summary by CodeRabbit