feat(deps): update tower crate to v0.5.2 and fix partial retry logic
#22431
+175
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adjustments of Buffer type definition in Tower 0.5 - As policy is directly modified in Tower 0.5. Removed the policy part in the RetryPolicyFuture. - The change args to mutable for the retry function and clone_request function. It's changed in Tower 0.5. - Changed the RetryPolicyFuture Output to (). This is also changed in Tower 0.5. - Modified some tests as policy is now modified in advance function;
…ls a RetryPartialFunction trait to modify the old request. In the elasticsearch sink. When there are errors in the response, the response's status_codes are keeped in a closure which is later used by the modify_request func in RetryPartialFunction trait.
|
|
github-actions
bot
added
the
domain: sinks
pront
changed the title
tower crate to 0.5 and fix partial retry logic
pront
changed the title
tower crate to 0.5 and fix partial retry logictower crate to v0.5.2 and fix partial retry logic
|
Hi @Serendo, thank you for this PR! I think this is not a breaking change (from the perspective of Vector users). And also we will need a changelog to explain the fix. |
I have added a changlog fragment for this. |
…these stats ranges are related with the test params.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change Type
Is this a breaking change?
How did you test this PR?
I wrote a python server mocking the elasticsearch bulk api. which will give a response in which the first 5 documents are 201 created, and others are 429. I can see that a perticular document will only get one 201.
Does this PR include user facing changes?
Checklist
make check-allis a good command to run locally. This check isdefined here. Some of these
checks might not be relevant to your PR. For Rust changes, at the very least you should run:
cargo fmt --allcargo clippy --workspace --all-targets -- -D warningscargo nextest run --workspace(alternatively, you can runcargo test --all)Cargo.lock), pleaserun
dd-rust-license-tool writeto regenerate the license inventory and commit the changes (if any). More details here.References
Closes: #140
#14891