Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): Revert add http sink tls cert/key to config::watcher #22434

Merged
merged 1 commit into from
Feb 13, 2025
Merged

fix(cli): Revert add http sink tls cert/key to config::watcher #22434

merged 1 commit into from
Feb 13, 2025

Conversation

pront
Copy link
Member

@pront pront commented Feb 13, 2025

Reverts #22386

Based on #17283 (comment)

@pront pront requested a review from a team as a code owner February 13, 2025 18:16
@pront pront requested a review from jszwedko February 13, 2025 18:16
@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label Feb 13, 2025
@pront pront changed the title Revert "feat(cli): Add http sink tls cert/key to config::watcher" revert: "feat(cli): Add http sink tls cert/key to config::watcher" Feb 13, 2025
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Feb 13, 2025
@pront pront changed the title revert: "feat(cli): Add http sink tls cert/key to config::watcher" revert(cli): "feat(cli): Add http sink tls cert/key to config::watcher" Feb 13, 2025
@jszwedko jszwedko changed the title revert(cli): "feat(cli): Add http sink tls cert/key to config::watcher" fix(cli): Revert add http sink tls cert/key to config::watcher Feb 13, 2025
@pront pront enabled auto-merge February 13, 2025 18:18
jszwedko
jszwedko approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with reverting until this feature can be fully implemented.

@datadog-vectordotdev
Copy link

Datadog Report

Branch report: revert-22386-master
Commit report: d9b7a3f
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.5s Total Time

@pront pront added this pull request to the merge queue Feb 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2025
@pront pront added this pull request to the merge queue Feb 13, 2025
Merged via the queue into master with commit 39973ab Feb 13, 2025
61 of 65 checks passed
@pront pront deleted the revert-22386-master branch February 13, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jszwedko jszwedko jszwedko approved these changes

Assignees
No one assigned
Labels
domain: sinks Anything related to the Vector's sinks no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pront @jszwedko