fix(ci): E2E comment triggers #22443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pront
added
the
no-changelog
Datadog ReportBranch report: ✅ 0 Failed, 7 Passed, 0 Skipped, 25.43s Total Time |
jszwedko
reviewed
Feb 14, 2025
| @@ -130,24 +130,23 @@ jobs: | |||
| - run: docker image prune -af ; docker container prune -f | |||
| - name: e2e-datadog-logs | |||
| if: ${{ startsWith(github.event.review.body, '/ci-run-e2e-datadog-logs') | |||
| || startsWith(github.event.review.body, '/ci-run-integration-all') | |||
There was a problem hiding this comment.
Did you mean to delete this one? I've used it before to run all integration tests.
There was a problem hiding this comment.
Yes, we can use /ci-run-all to run all E2E and IT tests. And then we also have:
- /ci-run-e2e-all (all E2E)
- /ci-run-integration-all (all IT)
There was a problem hiding this comment.
I think /ci-run-all runs all tests, not just E2E and IT tests 🤔
I see though,/ci-run-integration-all shouldn't have been here since it was an e2e test. 👍
jszwedko
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix CI comment triggers.
To be rebased on #22441
Change Type
Is this a breaking change?
How did you test this PR?
Does this PR include user facing changes?
Checklist
make check-allis a good command to run locally. This check isdefined here. Some of these
checks might not be relevant to your PR. For Rust changes, at the very least you should run:
cargo fmt --allcargo clippy --workspace --all-targets -- -D warningscargo nextest run --workspace(alternatively, you can runcargo test --all)Cargo.lock), pleaserun
dd-rust-license-tool writeto regenerate the license inventory and commit the changes (if any). More details here.References