Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify dependency on gqlgen #351

Closed
wants to merge 1 commit into from

Conversation

HaraldNordgren
Copy link

No description provided.

@HaraldNordgren HaraldNordgren changed the title create dependency on gqlgen Create dependency on gqlgen Feb 11, 2025
@HaraldNordgren HaraldNordgren changed the title Create dependency on gqlgen Clarify dependency on gqlgen Feb 11, 2025
@StevenACoffman
Copy link
Collaborator

@HaraldNordgren I'm sorry, I may been unclear in #346
gqlparser does not have a direct dependency on gqlgen, but gqlgen definitely depends directly on gqlparser.
However, GraphQL introspection is a feature that currently requires both gqlgen and the gqlparser to use the exact same GraphQL spec version.

We could move some of the gqlgen introspection code over here and that might resolve the problem in a different way than what you are currently doing.

@HaraldNordgren
Copy link
Author

@StevenACoffman Fair enough, I wanted to try it out. Seems the CI is failing anyway. I will close this one.

@StevenACoffman
Copy link
Collaborator

I'm actually pretty excited that you're interested in helping, so I don't mean to discourage you in any way!

@HaraldNordgren
Copy link
Author

@StevenACoffman Good to hear!

Moving the introspection code (I guess you mean duplicating it) could be interesting. I guess you have a better grasp of that code than I do, do you want to do it? 🤗😬😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants