feat(core) Add CreateUser method to ExternalAuthenticationService Helper Class #2986
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add createUser method to external authentication helper to support the case where user is authenticated
via external provider without email. There is a case (ie mobile app only store) where we only want authenticated users to see products and and be able to add to carts. This is also useful for anti-scraping.
I also returned savedUser from all methods for consistency and added type for missing method.
Breaking changes
Nope
Screenshots
You can add screenshots here if applicable.
Checklist
📌 Always:
I added description to the method
👍 Most of the time: