Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core) Add CreateUser method to ExternalAuthenticationService Helper Class #2986

Closed
wants to merge 2 commits into from

Conversation

arrrrny
Copy link
Contributor

@arrrrny arrrrny commented Jul 31, 2024

Description

add createUser method to external authentication helper to support the case where user is authenticated
via external provider without email. There is a case (ie mobile app only store) where we only want authenticated users to see products and and be able to add to carts. This is also useful for anti-scraping.

I also returned savedUser from all methods for consistency and added type for missing method.

Breaking changes

Nope

Screenshots

You can add screenshots here if applicable.

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

I added description to the method

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

…e case where user is authenticated without email
Copy link

vercel bot commented Jul 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Aug 1, 2024 6:12am

Copy link
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@arrrrny
Copy link
Contributor Author

arrrrny commented Jul 31, 2024

I have read the CLA Document and I hereby sign the CLA

AHMET TOK

@arrrrny
Copy link
Contributor Author

arrrrny commented Jul 31, 2024

recheck

@arrrrny arrrrny changed the title Add CreateUser method to ExternalAuthenticationService Helper Class feat(core) Add CreateUser method to ExternalAuthenticationService Helper Class Aug 1, 2024
@arrrrny arrrrny closed this by deleting the head repository Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant