Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis cache plugin fixes #3303

Merged

Conversation

jacobfrantz1
Copy link
Contributor

Description

  • Fixes silent failures in the redis cache plugin when setting a ttl that is not a multiple of 1000.
  • I rounded the ttl to the nearest second, but I could be convinced to either ceil or floor the value.
  • Any other redis errors when setting keys should no longer be silent.
  • Negative ttls were being coerced to an unsigned int by redis (large positive value), so I added a check.
  • Added tests related to these issues

Breaking changes

  • No known breaking changes

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

Copy link

vercel bot commented Jan 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jan 6, 2025 7:38pm

Copy link

sonarqubecloud bot commented Jan 6, 2025

@michaelbromley michaelbromley merged commit b631781 into vendure-ecommerce:master Jan 9, 2025
31 checks passed
@michaelbromley
Copy link
Member

Thanks for the fixes and 🤝 the tests

@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants