Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from requests-kerberos to requests-gssapi #198

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pdecat
Copy link
Collaborator

@pdecat pdecat commented Sep 28, 2021

This PR switches aws-adfs from the unmaintained requests-kerberos to the actively maintained requests-gssapi.

This should resolve issues with pykerberos which is a dependency of requests-kerberos #189. Edit: #189 is about using the macOS provided version of python which is buggy.

Some people looked into switching requests-kerberos from the unmaintained pykerberos to the maintained kerberos,
but the last comment seems to indicate it is probably easier to switch from requests-kerberos to requests-gssapi.

requests GSSAPI authentication library

Requests is an HTTP library, written in Python, for human beings. This library adds optional GSSAPI authentication support and supports mutual authentication.

It provides a fully backward-compatible shim for the old python-requests-kerberos library: simply replace import requests_kerberos with import requests_gssapi.

See https://pypi.org/project/requests-gssapi/
and https://github.com/pythongssapi/requests-gssapi

@pdecat
Copy link
Collaborator Author

pdecat commented Sep 28, 2021

Hi @bodgit, as the author of #144, would you be able to verify this PR does not break your use case with Kerberos support?

@pdecat pdecat force-pushed the switch_to_requests_gssapi branch 2 times, most recently from 8b1ff17 to db8db77 Compare September 29, 2021 09:45
@bodgit
Copy link
Contributor

bodgit commented Sep 29, 2021

Hi @bodgit, as the author of #144, would you be able to verify this PR does not break your use case with Kerberos support?

We've actually almost entirely migrated away from ADFS to use Okta instead and switched from this package to gimme-aws-creds to generate AWS credentials, so I don't use this now. Feel free to merge!

@pdecat
Copy link
Collaborator Author

pdecat commented Sep 29, 2021

@bodgit ok, thanks for the feedback.

@pdecat pdecat force-pushed the switch_to_requests_gssapi branch 19 times, most recently from 162eca1 to 2dd60ce Compare October 4, 2021 10:12
@pdecat
Copy link
Collaborator Author

pdecat commented Nov 16, 2021

requests-kerberos v0.13.0 was recently released and switched its Kerberos dependencies:

Change Kerberos dependencies to pyspnego to modernise the underlying Kerberos library that is used.

See https://github.com/requests/requests-kerberos/releases/tag/v0.13.0
and requests/requests-kerberos#163

@pdecat pdecat marked this pull request as draft November 16, 2021 11:27
@pdecat pdecat added the dependencies Pull requests that update a dependency file label Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants