Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Enable XML Validation Workflow #1497

Merged
merged 1 commit into from
Feb 15, 2025
Merged

Conversation

Jertzukka
Copy link
Contributor

Enable workflow on correct branch and make script executable.

@idrassi
Copy link
Member

idrassi commented Feb 15, 2025

Welcome back!
Thank you for the fix and of course for the code since it is yours.

@idrassi idrassi merged commit 98fa395 into veracrypt:master Feb 15, 2025
1 check passed
@harryytm
Copy link
Contributor

harryytm commented Feb 20, 2025

xmlvalidate error on PR #1486

import pkg from '../../package.json' assert { type: 'json' };
                                     ^^^^^^

SyntaxError: Unexpected identifier 'assert'
    at compileSourceTextModule (node:internal/modules/esm/utils:338:16)
    at ModuleLoader.moduleStrategy (node:internal/modules/esm/translators:106:18)
    at #translate (node:internal/modules/esm/loader:473:12)
    at ModuleLoader.loadAndTranslate (node:internal/modules/esm/loader:520:27)
    at async ModuleJob._link (node:internal/modules/esm/module_job:115:19)

Node.js v23.8.0

@idrassi
Copy link
Member

idrassi commented Feb 20, 2025

@harryytm Thanks for the report. It looks like the new Node.js version 23.8 is causing an issue with fast-xml-parser. Since it was working before, I think the solution is to force the use of LTS version of Node.js (20.x or 22.x for example).

I will try first to reproduce the issue on my side before pushing any changes.

@idrassi
Copy link
Member

idrassi commented Feb 20, 2025

I have done tested under Ubuntu 24.04 with latest Node.js 23.8 and I discovered that the issue is caused by the latest version series 5.x of fast-xml-parser: if I use version 4.5.2 which is the latest of 4.x series, the issue doesn't occur.

So I will push a change to force the use of version 4.5.2 of fast-xml-parser in this Github workflow.

idrassi added a commit that referenced this pull request Feb 20, 2025
…fixed version of fast-xml-parser 4.5.2

latest version 5.x of fast-xml-parser causes described in #1497 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants