docs: add best practice for fonts persistence #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shuding
approved these changes
Oct 6, 2024
| @@ -317,6 +317,11 @@ await satori( | |||
|
|
|||
| Multiple fonts can be passed to Satori and used in `fontFamily`. | |||
|
|
|||
| > [!TIP] | |||
| > We recommend you define global fonts instead of creating a new object and pass it to satori for better performace, if your fonts do not change. [Read it for more detail](https://github.com/vercel/satori/issues/590) | |||
There was a problem hiding this comment.
Suggested change
| > We recommend you define global fonts instead of creating a new object and pass it to satori for better performace, if your fonts do not change. [Read it for more detail](https://github.com/vercel/satori/issues/590) | |
| > We recommend defining fonts on the global level, instead of creating a new object and pass it to Satori on each generation. This generally improves the performance. More details can be found on [this issue](https://github.com/vercel/satori/issues/590). |
|
Thanks a lot @Jackie1210! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jakeinflab made great investigation, check here. If we can follow best practices, we don't need to use
hashid + Map. What do you think? @shuding