-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
249: Basic navigation and project folder structure #256
base: main
Are you sure you want to change the base?
249: Basic navigation and project folder structure #256
Conversation
…ing' into 249-basic-navigation-and-project-folder-structure
…navigation-and-project-folder-structure # Conflicts: # lib/main.dart # pubspec.lock
I merged branches of not already merged pull requests to this branch. Not sure, if this was the right way? Please let me know. |
Hmm, I personally think that this should be avoided. This way, reviewing your PR is quite hard as it is not clear at all which changes stem from your PR and which from other PRs until all other PRs are merged to your base branch (i.e. main). Usually, branches and PRs should only include the commits of max. one other branch than main imo, so you can just base the PR on that branch instead of main (see e.g. #255). Otherwise, its probably better to focus on merging the other PRs fast. |
Yes, in this case the other PRs should be merged fast.
But I agree with you, it's hard to review and not clear. |
Short description
Adds bottom navigation bar, main routes and screens.
Proposed changes
Side effects
None.
Testing
Navigate to the main routes of the app.
Resolved issues
Fixes: #249