249: Basic navigation and project folder structure

[volkramweber]

Short description

Adds bottom navigation bar, main routes and screens.

Proposed changes

• Adds router with main routes
• Adds bottom navigation bar including links to the main routes

Side effects

None.

Testing

Navigate to the main routes of the app.

Resolved issues

Fixes: #249

---

[volkramweber]

I merged branches of not already merged pull requests to this branch. Not sure, if this was the right way? Please let me know.

[steffenkleinle]

I merged branches of not already merged pull requests to this branch. Not sure, if this was the right way? Please let me know.

Hmm, I personally think that this should be avoided. This way, reviewing your PR is quite hard as it is not clear at all which changes stem from your PR and which from other PRs until all other PRs are merged to your base branch (i.e. main). Usually, branches and PRs should only include the commits of max. one other branch than main imo, so you can just base the PR on that branch instead of main (see e.g. #255). Otherwise, its probably better to focus on merging the other PRs fast.
Specifically in this case, is your PR really dependent/based on any of the other PRs?

[volkramweber]

I merged branches of not already merged pull requests to this branch. Not sure, if this was the right way? Please let me know.

Hmm, I personally think that this should be avoided. This way, reviewing your PR is quite hard as it is not clear at all which changes stem from your PR and which from other PRs until all other PRs are merged to your base branch (i.e. main). Usually, branches and PRs should only include the commits of max. one other branch than main imo, so you can just base the PR on that branch instead of main (see e.g. #255). Otherwise, its probably better to focus on merging the other PRs fast. Specifically in this case, is your PR really dependent/based on any of the other PRs?

Yes, in this case the other PRs should be merged fast.
This PR is dependent on the other PRs/Issues:

• PR 251: Configure linting, formatting and typechecking #254 - I wanted to commit with the right linting and formatting settings
• PR 252: Setup translations with slang #255 - I needed translations for the labels of the bottom menu items

But I agree with you, it's hard to review and not clear.
Let's merge the other PRs fast.
I hope these kind of dependencies between PRs do not happen in the future.