Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VZ-8104 make user numeric in Dockerfile #1

Open
wants to merge 39 commits into
base: oracle/release/0.3.3
Choose a base branch
from

Conversation

mbenmclean
Copy link

change user to numeric in order to ensure running as nonroot

markxnelson and others added 30 commits February 22, 2021 15:17
Signed-off-by: Mark Nelson <[email protected]>
Signed-off-by: Mark Nelson <[email protected]>
Signed-off-by: Mark Nelson <[email protected]>
* update docker file given base image update
Revert VZ 3778: K8s 1.22 changes on hold.
…remove_repo

Remove unneeded yum repo from Dockerfile
…in OAM (crossplane#12)

* restore finalizers during trait rendering
Signed-off-by: Mark Nelson <[email protected]>
@@ -1,3 +1,4 @@
//go:build !ignore_autogenerated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this intentional?

@@ -107,6 +107,7 @@ func ValidateComponentObject(obj *v1alpha2.Component) field.ErrorList {
var _ inject.Client = &ValidatingHandler{}

// InjectClient injects the client into the ComponentValidatingHandler

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like an accidental newline?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm not sure how those got added in

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or did gofmt force these ws changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.