workflow: enable all OS in mediasoup-node

versatica · May 21, 2024 · b3044ad · b3044ad
1 parent 85784ad
commit b3044ad
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/.github/workflows/mediasoup-node.yaml b/.github/workflows/mediasoup-node.yaml
@@ -13,14 +13,14 @@ jobs:
     strategy:
       matrix:
         ci:
-          # - os: ubuntu-20.04
-            # node: 18
-          # - os: ubuntu-22.04
-            # node: 20
-          # - os: macos-12
-            # node: 18
-          # - os: macos-14
-            # node: 20
+          - os: ubuntu-20.04
+            node: 18
+          - os: ubuntu-22.04
+            node: 20
+          - os: macos-12
+            node: 18
+          - os: macos-14
+            node: 20
           - os: windows-2022
             node: 20
         build-type:

diff --git a/node/src/workerChannel/binding.gyp b/node/src/workerChannel/binding.gyp
@@ -51,7 +51,6 @@
               # 2 - MultiThreadedDLL (/MD)
               # 3 - MultiThreadedDebugDLL (/MDd)
               'RuntimeLibrary': '<(runtime_library)',
-              # 'AdditionalOptions': [ '/MT' ],
             },
             'VCLinkerTool': {
               'AdditionalOptions': ['/FORCE:MULTIPLE'],