Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using IPC to handle navigations #222

Merged
merged 22 commits into from
Feb 4, 2025

Conversation

Legend-Master
Copy link
Contributor

No description provided.

@Legend-Master Legend-Master marked this pull request as ready for review November 8, 2024 05:10
This was referenced Nov 8, 2024
@wusyong
Copy link
Member

wusyong commented Nov 11, 2024

I think before we start dealing with bi-direction communication API, there should be a dedicated IPC channel that could send from core crate to verso crate. Could you test if this could be done upon we start the IPC channel here?

@Legend-Master
Copy link
Contributor Author

I thought about it before, but now I think I would like to go with the event listener approach that we only send an IPC sender to the core crate when we need info from it, instead of always listen to messages from the core crate

@Legend-Master Legend-Master requested a review from wusyong January 23, 2025 02:55
@pewsheen pewsheen added this pull request to the merge queue Feb 4, 2025
Merged via the queue into versotile-org:main with commit 11529d5 Feb 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants