Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting init script through cli #246

Merged
merged 16 commits into from
Feb 6, 2025

Conversation

Legend-Master
Copy link
Contributor

No description provided.

@Legend-Master Legend-Master mentioned this pull request Nov 21, 2024
17 tasks
src/webview.rs Outdated
@@ -82,6 +83,11 @@ impl Window {
w
);
}
EmbedderMsg::LoadStart => {
if let Some(init_script) = &self.init_script {
execute_script_async(&sender, &webview_id, init_script);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why doesn't it just use usercript?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to use it later on for the webview controller's APIs, for the CLI usage, we can also add in userscript along side this, since that one needs to take a file instead of a string

@Legend-Master Legend-Master requested a review from wusyong January 23, 2025 03:24
@versotile-org versotile-org deleted a comment Feb 4, 2025
Co-authored-by: Jason Tsai <git@pews.dev>
Signed-off-by: Tony <68118705+Legend-Master@users.noreply.github.com>
@pewsheen pewsheen enabled auto-merge February 6, 2025 11:26
@pewsheen pewsheen added this pull request to the merge queue Feb 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2025
@Legend-Master
Copy link
Contributor Author

Seems like the download failed for mozjs on windows and linux somehow, maybe re-try it?

@pewsheen pewsheen added this pull request to the merge queue Feb 6, 2025
Merged via the queue into versotile-org:main with commit 30ad32d Feb 6, 2025
6 checks passed
@Legend-Master Legend-Master deleted the init-script branch February 6, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants