Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new encode function #337

Closed
wants to merge 2 commits into from
Closed

new encode function #337

wants to merge 2 commits into from

Conversation

Xpecya
Copy link

@Xpecya Xpecya commented May 24, 2022

#336 I opened a new PR @pmlopes Thank you

@pmlopes
Copy link
Member

pmlopes commented May 25, 2022

@Xpecya give a look at #338

This PR may work on the full redis stack API. I'm thinking that using varargs can make it easier for the end user. If we can optimize the encoding to be less GC even better

@Xpecya
Copy link
Author

Xpecya commented May 25, 2022

@pmlopes users would more likely to use get/set/incr... instead of send(command, args) or send(request) in my opinion, so it doesn't really matter how the args are. Just make sure the user interfaces(get/set/incr etc) stay the same. I agree that this PR may work on #338, perhaps the first thing is to do some modification on the Request class, store the Object[] directly instead of create a ArrayList first... I'll try later on that branch and open a new PR

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants