-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created bridge event on client consumer handler to support backpressure and other use cases #71
Open
erik777
wants to merge
32
commits into
vert-x3:master
Choose a base branch
from
Acuity-vct:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did not see a way to exclude files from the PR, so it includes our custom pom-as.xml which is not needed for the PR, but needed to build and deploy in our enviornment. Remaining are changes to two java files that make up this PR. You can delete pom-as.xml. |
…to ci-4.x file (cont)
syncing to upstream branch 4.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We needed a way to manage backpressure of messages that clients consume. I simply used the current BridgeEvent handler and extended it to call checkCallHook from inside the consumer handler under the "register" case.
This allowed us, and anyone else, to intercept the messages with the event handler and drop them when we detected backpressure on the socket, which the bridge handling provides access to. The backpressure code is not included in this PR, but is possible by the changes in the PR.
I used the BridgeEventType.RECEIVE, which was not previously used on the server side of the bridge because it's doc description best fit this type of message.
Conformance:
Your commits should be signed and you should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines