Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer prefix verilog package identifiers with veryl project names #327

Closed
wants to merge 2 commits into from

Conversation

nblei
Copy link
Contributor

@nblei nblei commented Jul 30, 2023

This is in order to deal with the issue I raised #324

I am not sure entirely why module and package names are prefixed with project names --- perhaps because verilog has no real module system or namespace system. If that's the goal, then emitter.rs should be changed to also prefix package identifiers in scoped_identifier.

@dalance
Copy link
Collaborator

dalance commented Jul 31, 2023

I intended that the prefix is used to realize package namespace.
So scoped_identifier should be prefixed by package identifier.

@nblei
Copy link
Contributor Author

nblei commented Jul 31, 2023

OK Dalance, I will withdraw this pull request because it seems like you have a better solution in mind.

@nblei nblei closed this Jul 31, 2023
@nblei nblei deleted the fix_pkg branch June 5, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants