Skip to content

Commit

Permalink
Merge pull request #2990 from vespa-engine/jobergum-patch-1
Browse files Browse the repository at this point in the history
Update screwdriver.yaml
  • Loading branch information
Jo Kristian Bergum authored Nov 14, 2023
2 parents cf7cc25 + 8e42b79 commit 6eeeafb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions en/nearest-neighbor-search-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -2058,7 +2058,7 @@ In this case, we set it to 1, which disables adjusting the `targetHits` upwards.

<div class="pre-parent">
<button class="d-icon d-duplicate pre-copy-button" onclick="copyPreContent(this)"></button>
<pre data-test="exec" data-test-assert-contains='totalCount": 1'>
<pre data-test="exec" data-test-assert-contains='totalCount":'>
$ vespa query \
'yql=select title, artist, tags from track where {targetHits:10}nearestNeighbor(embedding,q) and tags contains "rock"' \
'hits=2' \
Expand All @@ -2069,7 +2069,7 @@ $ vespa query \
'input.query(q)=embed(e5, "Total Eclipse Of The Heart")'
</pre>
</div>
Since we are post-filtering without upward adjusting the targetHits, we end up with just one hit.
Since we are post-filtering without upward adjusting the targetHits, we end up with fewer hits.

Changing the query to limit to a tag which is less frequent, for example, `90s`, which
matches 1,695 documents or roughly 1.7%, will cause Vespa to fall back to exact search as the estimated filter hit count
Expand Down
2 changes: 1 addition & 1 deletion screwdriver.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ shared:
install-deps-new: &install-deps-new
install-deps-new: |
dnf config-manager --add-repo=https://download.docker.com/linux/centos/docker-ce.repo
dnf -y install docker-ce protobuf-compiler protobuf-devel --nobest
dnf -y install docker-ce protobuf-compiler protobuf-devel python3 python3-pip --nobest
python3 -m pip install --upgrade pip
python3 -m pip install -qqq -r test/requirements.txt --user
python3 -m pip install -qqq pytest nbmake --user
Expand Down

0 comments on commit 6eeeafb

Please sign in to comment.