feat(ci/cd): set version to 0.dev #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the pyvespa version to 0.dev in the pyproject.toml and vespa/__init__.py files. The changes are made to ensure the project's version is accurately reflected across the codebase.
thomasht86
reviewed
Aug 29, 2024
This commit enables automatic PyPi release for the 'pyvespa' library when a new release is published on GitHub. Previously, the release workflow was disabled, but this change now triggers the release process when a new release is published. The key changes are: - Modify the release trigger to listen for 'published' events instead of 'workflow_dispatch' - Add an environment variable 'RELEASE_REF' to ensure the version is available, even if the 'GITHUB_REF' variable is not set correctly - Update the version extraction logic to use the 'RELEASE_REF' variable instead of 'GITHUB_REF'
esolitos
changed the title
thomasht86
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
0.devWhy
Before this change each time we would release a new version we would also need to update the version in this repo (examples here and here, ...), this is s superfluous step which was required mostly to ensure that the CI workflows would work when doing
pip install -e .as this requires a valid version.After some discussion with @thomasht86 we reached the conclusion that we can set the ".dev" version (where X is the current major version) in those files and we update the version in those files during the release process for pypi.