add nomic-ai modernbert #4320
Merged
add nomic-ai modernbert #4320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorncs
previously approved these changes
Jan 20, 2025
tests/search/embedding/10-docs.json
Outdated
| @@ -0,0 +1,13 @@ | |||
| [ | |||
| { "remove": "id:test:doc::1" }, | |||
There was a problem hiding this comment.
Why is the remove operation neccessary?
There was a problem hiding this comment.
it's only there to remove the single doc (in docs.json) used by the other tests. Will clean up.
| { | ||
| "kw": "hello", | ||
| "qtext": "Hello world", | ||
| "dtext": "Hello world", |
| #puts("OK[#{idx}]: #{expval}") | ||
| end | ||
|
|
||
| def check_prefix_suffix(expected_v, actual_v, fixlen) |
There was a problem hiding this comment.
The purpose of this method is just to skip comparison of the middle element (index 5)?
There was a problem hiding this comment.
no, it's to skip the middle 758 elements in the actual vector - comparing just the 5 first and last. index 5 is a placeholder from where the python "torch" library prints "...".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bjorncs please review
@glebashnik FYI