feat(ci): update release tag detection logic #32467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes in this commit update the logic used to detect the previous release tag in the CI workflow. Previously, the workflow was using the first release tag that matched the version pattern, but this could lead to incorrect results if there were multiple release tags that matched the pattern. The updated code now retrieves all the release tags that match the pattern and selects the most recent one, ensuring that the correct previous tag is used for comparison.
aressem
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update the logic used to detect the previous release tag in the CI workflow.
Why
Previously, the workflow was using the first release tag, but this could lead to incorrect results, if for example the "Language Server" was released.
The updated code now retrieves all the release tags and selects the most recent one that matches the pattern.
Additional info
The previous change (PR #32433) was tested in another repo, but that repo only had 1 type of releases, so this was not seen.