Fix/Api-endpoints-no-data #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theodorklauritzen
requested review from
Paulijuz and
JohanHjelsethStorstad
and removed request for
Paulijuz
JohanHjelsethStorstad
changed the title
|
I agree with Johan. Having random scripts seems unmaintainable. Wouldn't this be solvable with a simple check when creating a user. Or what about seeding a standard admin user? |
|
I agree that a lot of Python scripts aren't good practice. Maybe I'm not aware of a nice way to get admin access in production now during testing, but for now, this is a fast way to give a single user admin access. The script will be deleted when we release PN, since we'll never clear the database. |
|
We could seed a admin user to prod that would also work fine. It's just nice to have a easy way to get admin permissions in prod |
JohanHjelsethStorstad
changed the title
JohanHjelsethStorstad
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very useful for the first user on the system. Maybe we need another solution longterm.
In addition I fixed a bug in
apiHandlerat endpoints that don't expect any data.