Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor container image management #800

Merged

Conversation

CuriousGeorgiy
Copy link
Member

Summary

Closes #799
Part of #794

Implementation Notes ⚒️

  • Introduced a new module ctriface/image and a new ImageManager object to manage container images.

External Dependencies 🍀

  • N/A.

Breaking API Changes ⚠️

  • N/A.

ustiugov
ustiugov previously approved these changes Sep 5, 2023
Copy link
Member

@ustiugov ustiugov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CuriousGeorgiy
Copy link
Member Author

@ustiugov I changed one line, but GitHub dismissed the review from you for some reason, could you please take a glance?

Copy link
Member

@ustiugov ustiugov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Encapsulate container image management into a separate module that provides
an image manager class.

Closes vhive-serverless#799
Part of vhive-serverless#794

Signed-off-by: Georgiy Lebedev <[email protected]>
@ustiugov ustiugov force-pushed the image-management-refactoring branch from 0c154fc to 2ac0acd Compare September 8, 2023 10:57
@CuriousGeorgiy CuriousGeorgiy enabled auto-merge (rebase) September 8, 2023 10:58
@ustiugov ustiugov disabled auto-merge September 10, 2023 09:36
@ustiugov ustiugov merged commit 993b486 into vhive-serverless:main Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor container image management
2 participants