-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added files for compression benchmark #998
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69a56cc
to
63987ed
Compare
0087f8f
to
12d5ddc
Compare
dhschall
reviewed
Jul 16, 2024
benchmarks/compression/yamls/knative/kn-compression-python.yaml
Outdated
Show resolved
Hide resolved
dhschall
reviewed
Jul 16, 2024
ec75820
to
14982fa
Compare
dhschall
requested changes
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all quite good. Just a minor change to make the test work
benchmarks/compression/yamls/knative/kn-compression-python.yaml
Outdated
Show resolved
Hide resolved
3b24933
to
ec88465
Compare
dhschall
reviewed
Jul 18, 2024
7b7a37f
to
ada1351
Compare
Signed-off-by: L Lakshmanan <[email protected]@research.iiit.ac.in>
ada1351
to
3b9b969
Compare
dhschall
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
Thank you @KarthikL1729 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added all the files for the compression benchmark. Tested with vSwarm-proto and docker-compose.