Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws sdk version #256

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

unixninja92
Copy link
Contributor

@unixninja92 unixninja92 commented Jun 17, 2024

I updated github.com/aws/aws-sdk-go-v2 to v1.28.0 to support new auth including IRSA and Pod Identities in EKS. This updated the other aws sdk versions as well. I ran tests and everything passed.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. kind:enhancement New feature or request labels Jun 17, 2024
@devstein devstein self-requested a review June 17, 2024 23:37
Copy link
Collaborator

@devstein devstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing @unixninja92! I'll try cut a release soon

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 17, 2024
@devstein devstein merged commit b8acbfb into viaduct-ai:master Jun 17, 2024
3 checks passed
@truongnht
Copy link

@devstein are you sure this merge will work? I thought the aws sdk come from sops?

@devstein
Copy link
Collaborator

good call and good timing -> #258

@truongnht
Copy link

@devstein if you look into #258, you would see the aws sdk version turns out differently (higher version than this PR). The indirect comment means it is indirectly deduced from sops. So I hope this kind of PR would be rejected next time to avoid confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants