Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSDK-5238 - fix cmake for bullseye #205

Merged
merged 9 commits into from
Jan 31, 2024
Merged

RSDK-5238 - fix cmake for bullseye #205

merged 9 commits into from
Jan 31, 2024

Conversation

stuqdog
Copy link
Member

@stuqdog stuqdog commented Jan 25, 2024 •
edited
Loading

Major changes

  • Move bullseye fixes into separate bespoke step. Not sure why this was working before but not anymore, but either way it's cleaner now.
  • Upload tarball of directories for release rather than trying to add whole directory.

@stuqdog stuqdog marked this pull request as ready for review January 25, 2024 21:54
@stuqdog stuqdog requested a review from a team as a code owner January 25, 2024 21:54
@stuqdog stuqdog requested review from njooma and purplenicole730 and removed request for a team January 25, 2024 21:54
@stuqdog stuqdog marked this pull request as draft January 26, 2024 14:26
@stuqdog stuqdog marked this pull request as ready for review January 26, 2024 14:53
purplenicole730
purplenicole730 reviewed Jan 29, 2024
View reviewed changes
Copy link
Member

@purplenicole730 purplenicole730 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with cmake and what a workflow entails, so I don't have the knowledge necessary to review this PR.

@stuqdog stuqdog merged commit faf5d76 into viamrobotics:main Jan 31, 2024
3 checks passed
@stuqdog stuqdog deleted the fix-bullseye-backports branch January 31, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purplenicole730 purplenicole730 purplenicole730 left review comments

@njooma njooma njooma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stuqdog @njooma @purplenicole730