Skip to content
This repository has been archived by the owner on Apr 19, 2023. It is now read-only.

Update Scanpy Docker image to use a fixed requirements file #21

Merged
merged 2 commits into from
Oct 23, 2019

Conversation

cflerin
Copy link
Member

@cflerin cflerin commented Oct 15, 2019

All Scanpy packages are now locked in requirements.txt. This fixes several bugs:

The virtualenv strategy is kept to try to keep the image size down.

The Scanpy package is installed in its own layer for quick image rebuilds (Scanpy is not present in requirements.txt).

Tested on the PBMC1k dataset with -entry single_sample, and completes without errors.

@cflerin cflerin requested a review from dweemx October 15, 2019 09:03
@ghuls ghuls mentioned this pull request Oct 15, 2019
Copy link
Contributor

@dweemx dweemx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me to merge!

@cflerin cflerin merged commit eb3f58c into master Oct 23, 2019
@cflerin cflerin deleted the scanpy_image branch October 23, 2019 09:06
dweemx added a commit that referenced this pull request Mar 19, 2020
KrisDavie pushed a commit that referenced this pull request Dec 7, 2020
KrisDavie pushed a commit that referenced this pull request Dec 7, 2020
KrisDavie pushed a commit that referenced this pull request Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants