Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle GC leaks of ManualEvent/ThreadWaiter gracefully #373

Merged
merged 1 commit into from
Dec 17, 2023

Conversation

s-ludwig
Copy link
Member

Avoids an assertion failure/abort() when a ThreadWaiter gets destroyed by the GC in the wrong thread. A warning is still generated, as this indicates that a thread was still waiting on a ManualEvent at runtime termination time and thus was not shut down properly.

Avoids an assertion failure/abort() when a ThreadWaiter gets destroyed by the GC in the wrong thread. A warning is still generated, as this indicates that a thread was still waiting on a ManualEvent at runtime termination time and thus was not shut down properly.
@s-ludwig s-ludwig requested a review from l-kramer December 17, 2023 10:19
@l-kramer l-kramer merged commit f24acdc into master Dec 17, 2023
@s-ludwig s-ludwig deleted the graceful_manualevent_gc_leak branch December 17, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants