developer delete items #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is a work in progress -- DELETE endpoints have not been tested. |
vichannnnn
reviewed
Jun 17, 2023
| @@ -14,6 +14,7 @@ import { | |||
| TableRow, | |||
| } from "@mui/material"; | |||
| import EditIcon from "@mui/icons-material/Edit"; | |||
| import DeleteIcon from '@mui/icons-material/Delete'; | |||
There was a problem hiding this comment.
We have an AdminDeleteIcon component, reuse that instead
There was a problem hiding this comment.
sorry for late reply, but id like to raise a bit of a nitpick. in AdminDeleteIcon a required prop is noteId but what we're deleting/editing is an instance of DataTypeKey = "categories" | "subjects" | "types";. Regardless I can repurpose the existing component, but the prop names are a bit misleading tbh
jasmine454
force-pushed
the
dev
branch
2 times, most recently
from
aedbfe3
to
6c90e50
Compare
vichannnnn
force-pushed
the
dev
branch
2 times, most recently
from
ad2e8f8
to
ae0e45c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
vichannnnn
force-pushed
the
dev
branch
3 times, most recently
from
411922f
to
4165535
Compare
vichannnnn
force-pushed
the
dev
branch
4 times, most recently
from
a1ff944
to
6442fc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the DELETE endpoint for /category /document_type and /subject as well as the UI for deletion.