-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: /account page #84
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #84 +/- ##
==========================================
- Coverage 71.00% 70.55% -0.46%
==========================================
Files 41 41
Lines 1635 1654 +19
==========================================
+ Hits 1161 1167 +6
- Misses 474 487 +13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
0934188
to
893c452
Compare
a79f7d0
to
38545d8
Compare
setRenderMenuType(<AccountDetails />); | ||
setSubtitle('View your account details here!'); | ||
setRenderMenuType(<AccountDetails changeEmailClick={changeEmailClick} />); | ||
setActiveElem([true, false, false]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this bad practice? in terms of scalability and maintainability. although it works, having a list of booleans is generally a bad idea, and i was thinking to use a mapping instead.
f774851
to
d21e1b4
Compare
79bfd89
to
c971693
Compare
e9e1b89
to
e272957
Compare
This PR implements a account page where users can change their email and password, as well as view the status of already uploaded notes.
WIP pls im suffering from a creative burnout
everything i build is ugly af