Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: /account page #84

Merged
merged 19 commits into from
Aug 4, 2023
Merged

feat: /account page #84

merged 19 commits into from
Aug 4, 2023

Conversation

SebassNoob
Copy link
Collaborator

This PR implements a account page where users can change their email and password, as well as view the status of already uploaded notes.

WIP pls im suffering from a creative burnout
everything i build is ugly af

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #84 (ee75cfa) into dev (08ca280) will decrease coverage by 0.46%.
The diff coverage is 38.09%.

@@            Coverage Diff             @@
##              dev      #84      +/-   ##
==========================================
- Coverage   71.00%   70.55%   -0.46%     
==========================================
  Files          41       41              
  Lines        1635     1654      +19     
==========================================
+ Hits         1161     1167       +6     
- Misses        474      487      +13     
Files Changed Coverage Δ
holy-grail-backend/backend/app/models/auth.py 38.77% <15.38%> (-1.67%) ⬇️
...ly-grail-backend/backend/app/api/endpoints/auth.py 70.58% <66.66%> (-1.76%) ⬇️
holy-grail-backend/backend/app/schemas/auth.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SebassNoob SebassNoob force-pushed the feat/account-page branch 2 times, most recently from 0934188 to 893c452 Compare July 24, 2023 01:40
@SebassNoob
Copy link
Collaborator Author

demo:
image

setRenderMenuType(<AccountDetails />);
setSubtitle('View your account details here!');
setRenderMenuType(<AccountDetails changeEmailClick={changeEmailClick} />);
setActiveElem([true, false, false]);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this bad practice? in terms of scalability and maintainability. although it works, having a list of booleans is generally a bad idea, and i was thinking to use a mapping instead.

@jasmine454 jasmine454 merged commit 9b4a61a into dev Aug 4, 2023
1 check passed
@vichannnnn vichannnnn deleted the feat/account-page branch August 26, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants