Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add module.exports so it can be required using browserify #94

Closed
wants to merge 2 commits into from
Closed

Add module.exports so it can be required using browserify #94

wants to merge 2 commits into from

Conversation

herpiko
Copy link

@herpiko herpiko commented Oct 18, 2015

No description provided.

@cetra3
Copy link
Collaborator

cetra3 commented Feb 10, 2016

Hi @herpiko,

I have a feeling this would break compatibility with non-browserify code, as module is not a defined function with vanilla javascript. Is there a more compatible way of doing this?

@zakhenry
Copy link

zakhenry commented Apr 7, 2016

@cetra3 I have implemented a more compatible export method in #115 which should close this PR

@herpiko
Copy link
Author

herpiko commented Apr 8, 2016

@xiphiaz Thank you. I'm sorry for this ugly PR. I'll close this.

@herpiko herpiko closed this Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@herpiko @cetra3 @zakhenry