Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interstitial fragment loading and buffering fixes #7002

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Feb 5, 2025

This PR will...

  • Fix streaming primary content over queued assets (base-stream-controller)
  • Fix "Main forward buffer length" warning on "seeked" for asset players (stream-controller)
  • Fix audio streaming gaps in asset players created after buffer is populated (handles incomplete fragment tracker - audio-stream-controller)
  • Fix incorrect interstitial buffering state after flush (interstitials-controller)
  • Fix advancing interstitial buffering advancement with append-in-place (interstitials-controller)
  • Fix interstitial start/end events at edge (playing last schedule item transitions with new interstitial) (interstitials-controller)
  • Fix asset player queue leaks (interstitials-controller clearAssetPlayer exits early resulting in playerQueue buildup)
  • Allow append-in-place at live edge with single playlist media selection (not allowed with alt-audio) (interstitials-schedule) resolves Interstitial append in place not happening when on live point #6995
  • Run skip buffer hole when stalling at a buffered range that ends prior to live playlist window start (gap-controller)
  • Add safety around asset player getters that throw when destroyed (interstitial-player)

Why is this Pull Request needed?

Improves Interstitials playback and seeking with config.appendInPlace enabled.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Resolves #6995

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

- Fix streaming primary content over queued assets
- Fix "Main forward buffer length" warning on "seeked" for asset players
- Fix audio streaming gaps in asset players created after buffer is populated (handles incomplete fragment tracker)
- Fix incorrect interstitial buffering state after flush
- Fix advancing interstitial buffering advancement with append-in-place
- Allow append-in-place at live edge with single playlist media selection (not allowed with alt-audio) (#6995)

Resolves #6995
@robwalch robwalch added this to the 1.6.0 milestone Feb 5, 2025
robwalch and others added 2 commits February 5, 2025 17:32
…ior to live playlist window start (gap-controller)

- Add safety around asset player getters that throw when destroyed
- Fix interstitial start/end events at edge (playing last schedule item transitions with new interstitial) (interstitials-controller)
- Fix asset player queue leaks (interstitials-controller `clearAssetPlayer` exits early resulting in `playerQueue` buildup)
…ulated (handles incomplete fragment tracker)
@robwalch robwalch changed the title Interstitial fragment loading and buffering fixes: Interstitial fragment loading and buffering fixes Feb 7, 2025
@robwalch robwalch merged commit 78e50de into master Feb 7, 2025
15 of 16 checks passed
@robwalch robwalch deleted the bugfix/interstitials-buffering-and-seeking branch February 7, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Interstitial append in place not happening when on live point
1 participant